Re: driver fence_type function

[<th...@tu...>]

Dave Airlie wrote:
>
>
> Hi Thomas (any anyone else :-)
>
> drm_buffer_object_validate gets passed new and old flags (using 
> bo->mem.mask/bo->mem.flags) but when it calls the i915 fence_type 
> function it only uses flags to check the fence type, now if this 
> buffer is getting validated RW when it wasn't before, it will get the 
> wrong fence type back..
>
> I've changed this in my tree to (bo->mem.mask | bo->mem.flags) which 
> or's the old and new types together but I wonder should it just be 
> checking the mask and not flags at all?
>
> Dave.
>
Yes, Dave.
The correct way should be to check mask only.

/Thomas