From: Dave A. <ai...@li...> - 2007-10-09 05:17:37
|
Hi Thomas (any anyone else :-) drm_buffer_object_validate gets passed new and old flags (using bo->mem.mask/bo->mem.flags) but when it calls the i915 fence_type function it only uses flags to check the fence type, now if this buffer is getting validated RW when it wasn't before, it will get the wrong fence type back.. I've changed this in my tree to (bo->mem.mask | bo->mem.flags) which or's the old and new types together but I wonder should it just be checking the mask and not flags at all? Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie Linux kernel - DRI, VAX / pam_smb / ILUG |