Re: [PATCH] r300_scratch in r300_cmdbuf.c is broken

[Panagiotis P. <pap...@cs...>]

Diving more into the code, I also found weird how the scratch cmd packet
is build in radeon_mm_use, in radeon_mm.c. I think it should be like in the 
attached patch.

On Wednesday 28 February 2007 22:33, Panagiotis Papadakos wrote:
> Updated patch. Fix a check.
>
> On Tuesday 27 February 2007 23:49, Panagiotis Papadakos wrote:
> > Hope this patch is OK.
> >
> > With it I no more get infinite messages like:
> >
> > Feb 27 15:48:39 localhost kernel: [drm:r300_do_cp_cmdbuf]
> > R300_CMD_SCRATCH Feb 27 15:48:39 localhost last message repeated 2 times
> > Feb 27 15:48:39 localhost kernel: [drm:r300_do_cp_cmdbuf] END
> > Feb 27 15:48:39 localhost kernel: [drm:drm_ioctl] pid=3538,
> > cmd=0xc0046456, nr=0x56, dev 0xe200, auth=1 Feb 27 15:48:39 localhost
> > kernel:
> > [drm:drm_ioctl] pid=3538, cmd=0x40046457, nr=0x57, dev 0xe200, auth=1 Feb
> > 27 15:48:39 localhost kernel: [drm:drm_ioctl] ret = fffffffc
> > Feb 27 15:48:39 localhost kernel: [drm:drm_ioctl] pid=3538,
> > cmd=0x40046457, nr=0x57, dev 0xe200, auth=1 Feb 27 15:48:39 localhost
> > kernel:
> > [drm:drm_ioctl] ret = fffffffc
> > Feb 27 15:48:39 localhost kernel: [drm:drm_ioctl] pid=3538,
> > cmd=0x40046457, nr=0x57, dev 0xe200, auth=1 Feb 27 15:48:39 localhost
> > kernel:
> > [drm:drm_ioctl] ret = fffffffc
> > Feb 27 15:48:39 localhost kernel: [drm:drm_ioctl] pid=3538,
> > cmd=0x40046457, nr=0x57, dev 0xe200, auth=1 Feb 27 15:48:39 localhost
> > kernel:
> > [drm:drm_ioctl] ret = fffffffc

-- 
Papadakos Panagiotis