Re: [PATCH] new radeon memory map fixes (#3)

[Tilman S. <ti...@co...>]

Benjamin Herrenschmidt [2006-02-14 09:37]:
>=20
> > Current DRM CVS HEAD doesn't work for me. However it does work with a
> > small patch applied:
> > https://bugs.freedesktop.org/show_bug.cgi?id=3D5450#c3
> >=20
> > Does it make sense to test that DRM code with the new X patch?
>=20
> You mean the DRM without my old patch doesn't work ? What was the
> symptom ? lockups ? So it worked in the short period of time when my old
> patch was in and broke when it was backed off right ?

If revision 1.71 of radeon_cp.c was the only change that was backed off,
then yes, in worked with your old patch.
When the single radeon_cp.c change was backed off, my screen got garbled
on X startup and the machine locked up hard.

> That's interesting... In that case I would have expected my new patch to
> work but you say you still have lockups.

As I said in my other mail, it's quite likely that the lock up was
introduced by bad Mesa code.

> Can you try all combinations of my old patch, new patch, X patch & !X
> patch and let me know what the results are ?

If it's perfectly stable with your latest patch and without that one bad
Mesa patch, would that convince you it's not a bug in DRM/DDX? :)

Regards,
Tilman

--=20
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?