From: Michel <mi...@da...> - 2006-01-27 11:52:35
|
Hi Ben, haven't got around to testing the patches, but they basically look good to me. Some comments: On Fri, 2006-01-27 at 12:15 +1100, Benjamin Herrenschmidt wrote: >=20 > > http://gate.crashing.org/~benh/radeon-memmap-7.0-2.diff There should be no need to check for info->cursor_offset =3D=3D 0 in the cursor functions. Longer term, I think we should just reserve a static FB region for the cursor upfront instead of going through all these hoops with EXA. Also, unless I'm missing something, you're removing the code that forces the display priority to high for Radeon 7200. > http://gate.crashing.org/~benh/radeon-memmap-drm-3.diff The way you handle backwards compatibility here is brilliant, thanks. The only minor issue I see is that the setparam ioctl can be called by unprivileged clients, but that applies to the existing colour tiling part as well, and it may not be a problem thanks to the offset fixups. --=20 Earthling Michel D=C3=A4nzer | Debian (powerpc), X and DRI develop= er Libre software enthusiast | http://svcs.affero.net/rm.php?r=3Ddaenzer |