From: Ian R. <id...@us...> - 2005-09-28 22:48:00
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I'm trying to get the patches attached to bug #2996 update. As part of that, I'm generating some smaller, more trivial patchs to commit to the tree /before/ RC1. I committed one really trivial one last night (the EvalComputeK stuff). This one is a little bit bigger, so I'd appreciate some review before I commit it. Basically, this refactors __glXImageSize and __glXImage3DSize into a single function. It replaces all calls to the old functions with calls to __glXImageSize with the new parameter list. I have also added 'target' as a parameter. This is a stepping stone to the code in patch #2410. Basically, if the texture target is one of GL_PROXY_*, the image size is always zero. This gathers all the checks for that into a single place. I have *not* modified the existing callers to take this into account. They still do their own checks for GL_PROXY_*. However, when the generated versions of those functions are added to the tree, they *will* rely on that. The code growth is mainly due to the new 40 line comment before __glXImageSize. I have tested this with a few of the texture using demos and tests from Mesa, including tunnel and texdown. 88be9d7346fffb7dbbb80fb6208ca6be glXImageSize-01.patch -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (GNU/Linux) iD8DBQFDOx2BX1gOwKyEAw8RAr4PAJ9R30UsO9+exxLqycJ6IEXjv1hokACfYaHt f3EK8/O3EA+DXFBKyhlhOg0= =3P/L -----END PGP SIGNATURE----- |