From: Dave A. <ai...@li...> - 2005-07-13 00:42:15
|
> > I've made a patch against the DRM code in CVS adding a few pieces that > were missing. > The code works for me on both radeon and r128. I've also tried to test > mga however the mga code in CVS doesn't seem to work at all right now. My guess would be idr's changes might need some compat work .. no idea though.. > > I am currently assigning completely arbitrary 32-bit tokens for maps > > just to see how that works, and it seems to be fine on my G5 (which > > has AGP and a radeon 9600 card). I think it would be preferable to > > use Egbert's code which uses the map->offset value if it fits into 32 > > bits in the longer term. > > I've changed this to use the address value if possible (if it fits into > 32bits and if the value has not been used as token for something else). > > This should help to maintain backward compatibility, on the other > hand it may not sufficiently deter people from using handles as base > addresses. > > DRM will work with either version. > The kernel does not use drm_handle_t (except for the mga driver) > where the use of it has been introduced just recently. I only consider published kernels and released X as stable ABIs so we can change the kernel stuff for the mga now... its in -mm but that is only experimental.. Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie Linux kernel - DRI, VAX / pam_smb / ILUG |