From: <bug...@fr...> - 2005-06-14 21:47:10
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=3248 ------- Additional Comments From mh...@ww... 2005-06-14 14:47 ------- I'm not convinced the patches attached above are the correct approach for this. The only safe way to determine wether a card is actually AGP or not, is to walk the PCI extended capabilities list. I wrote a patch for the Radeon driver a couple of years ago which does just that, which is present in Xorg 6.7.0 and later releases. My code was initially just a Radeon driver specific temporary implementation, but the code has been copied aparently into the SiS or some other driver (I don't recall which). Ideally, the code should be factored into os-support somewhere, and all drivers modified to use the genericized code instead of cut and pasting it everywhere. Initially I would have placed the code X server side, but perhaps it fits better in kernel land? Any thoughts? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |