Re: SW fallback: clipping bug [patch]

[Ville <sy...@sc...>]

On Thu, Oct 21, 2004 at 11:49:20PM +0200, Dieter N=FCtzel wrote:
> Am Freitag, 15. Oktober 2004 22:51 schrieb Nicolai Haehnle:
> > Hi,
> >
> > There is disagreement about the meaning of the CLIPSPAN _n parameter =
in
> > CVS.
> >
> > The drivers I have looked at and drivers/dri/common/spantmp.h treat _=
n as
> > the number of pixels in the span after clipping.
> > depthtmp.h and stenciltmp.h treat _n as the end+1 x coordinate of the=
 span.
> >
> > This inconsistency leads to artifacts when software fallbacks are hit=
 while
> > clipping is used, especially with partially obscured clients. The att=
ached
> > patch should fix these artifacts by changing depthtmp.h and stenciltm=
p.h
> > appropriately.
>=20
> What about this?
>=20
> Needed?

AFAICS the code is clearly broken and the fix is correct. The explanation=
=20
was a bit misleading though as it's the _n1 parameter and not _n that is=20
used incorrectly.

--=20
Ville Syrj=E4l=E4
sy...@sc...
http://www.sci.fi/~syrjala/