Re: New version of dyn-minor.patch

[Jon S. <jon...@gm...>]

inter_module can't be removed until we move to the drm_core design
with personality modules.  inter_module has always been in DRM and I
believe DRM is the only current user. I'm all for switching to the
drm_core design as soon as we can convince everyone to do it.

The DRM(probe) macro is there for the same reason. Without the macro
if you link two DRM drivers into the kernel you'll get symbol
conflicts. The macro gives them unique names. Switch to the drm_core
design and this code will be in the kernel once instead of twice and
the macro isn't needed.

In case people haven't been following, drm_core design means
converting DRM to a system like fbdev has. drm_core is a library
module which holds all of the common code. Personality modules
(radeon, sis, etc) then use the drm_code library to implement their
drivers. DaveA has done a few prototype of a drm_core design.

On Fri, 10 Sep 2004 23:14:46 +0100, Alan Cox <al...@lx...> wrote:
> On Gwe, 2004-09-10 at 22:30, Jon Smirl wrote:
> > No changes in the code, it's just regenerated against current DRM CVS
> 
> 
> -                               drm_probe(pdev, &DRM(pciidlist[i]));
> +                               DRM(probe)(pdev, &DRM(pciidlist[i]));
> 
> Seems to revert macro clean up work.
> 
> +       /* use the inter_module_get to check - as if the same module
> +               registers chrdev twice it succeeds */
> +       global = (drm_global_t *)inter_module_get("drm");
> 
> inter_module_* is deprecated
> 
> 



-- 
Jon Smirl
jon...@gm...