Re: 2.4.8.1+P6: radeon, dri & xruns

[Fernando P. Lopez-L. <na...@cc...>]

On Mon, 2004-08-23 at 11:43, Fernando Pablo Lopez-Lezcano wrote:
> On Mon, 2004-08-23 at 11:30, Ingo Molnar wrote:
> > i'll put the patch below into the -P8 patch. (change voluntary_resched()
> > to cond_resched() if you apply this to a vanilla kernel.)
> 
> I'll start a kernel build to test this on top of P7... 

A quick test confirms that no video related xruns happen with this patch
in place (Radeon Mobidity, running jack with 128x2 buffers and glxgears
to blast stuff to the screen). No ill effects so far either. Any more
comprehensive test I could run?

-- Fernando

> > --- linux/drivers/char/drm/drm_os_linux.h.orig	
> > +++ linux/drivers/char/drm/drm_os_linux.h	
> > @@ -14,7 +14,7 @@
> >  #define DRM_ERR(d)			-(d)
> >  /** Current process ID */
> >  #define DRM_CURRENTPID			current->pid
> > -#define DRM_UDELAY(d)			udelay(d)
> > +#define DRM_UDELAY(d)			do { voluntary_resched(); udelay(d); } while (0)
> >  /** Read a byte from a MMIO region */
> >  #define DRM_READ8(map, offset)		readb(((unsigned long)(map)->handle) + (offset))
> >  /** Read a dword from a MMIO region */