From: Mike M. <che...@ya...> - 2004-08-23 02:09:57
|
--- Jon Smirl <jon...@ya...> wrote: > Michel pointed out that all IOCTL calls hold the big kernel lock. > Releasing this lock is sure to case problems since the DRM code is not > designed to be reentrant. I don't know what it will take to fix locking > to allow this, maybe one of the original DRM authors will pop in here > with the answer. Until locking is adjusted we can't add the schedule > call. > From what I'v read, http://lwn.net/Articles/86859/, it's not a global kernel lock (I.E. it dosen't stop non-locked kernel code from running). So the only reason it effects audio performace is that well, read the article :) Also DRI allready runes with it off in ioctls, every time there is a sleep. This is why DRI has spinlocks, right? Now if we turn BKL off for our ioctls we defeat the pupose it was turned on for, what is that? Would it be posible to use differed execution instead of blindly droping the BKL? As for the other DRI-spinlocks the code presented by Ingo Molnar lookes correct, no arguments here. I just don't see why DRI needs to drop the BKL any sooner then any other part of the kernel? After all DRI dosen't request it, it's just one of many victums of the ioctl BKL. So I think it would be best to let upstream fix the DRI BKL problem. > --- Fernando Pablo Lopez-Lezcano <na...@cc...> wrote: > > > On Fri, 2004-08-20 at 22:59, Jon Smirl wrote: > > > I don't believe the DRM drivers are holding any global kernel locks > > > when they do wait_for_fifo. Any locks held would be internal to DRM > > and > > > can be changed if needed. > > > > There must be a lock. I used to use a patch that I found somewhere > > (that > > does conditional reschedules), but it triggers the "scheduling while > > lock held" kernel oops if you enable that option in the kernel > > configuration. > > > > -- Fernando > > > > > --- Lee Revell <rlr...@jo...> wrote: > > > > > > > On Sat, 2004-08-21 at 01:29, Jon Smirl wrote: > > > > > > > > > What's the right way to write a loop like this that meets the > > above > > > > > requirements and also satisfies the audio needs? > > > > > > > > > > > > > I think it depends on which locks you are holding, and what kind > > of > > > > locks they are. > > > > > > > > Lee > > > > > > > > > > > > > > > > > ===== > > > Jon Smirl > > > jon...@ya... > > > > > > > > > > > > __________________________________ > > > Do you Yahoo!? > > > Yahoo! Mail Address AutoComplete - You start. We finish. > > > http://promotions.yahoo.com/new_mail > > > > > > > ===== > Jon Smirl > jon...@ya... > > > > __________________________________ > Do you Yahoo!? > Yahoo! Mail - 50x more storage than other providers! > http://promotions.yahoo.com/new_mail > > > ------------------------------------------------------- > SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media > 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 > Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. > http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 > -- > _______________________________________________ > Dri-devel mailing list > Dri...@li... > https://lists.sourceforge.net/lists/listinfo/dri-devel > __________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail |