Re: [Dri-devel] [PATCH] Linux 2.6: Use userland firmware loading for Radeon, R128

[Michel <mi...@da...>]

On Mon, 2004-04-26 at 00:12, Nathanael Nerode wrote:
> This is the most up-to-date version.  Something very similar to this
> version is going into Debian's Linux kernel packages.  (Herbert Xu claims
> to have removed the memcpy's in *_firmware_loader.c, though I don't
> know exactly how it did it.)
                   ^^
I guess he (he's not a machine, is he? ;) uses le32_to_cpu() or a
variant thereof directly on the microcode data.


> +       if (dev_priv->is_r200)
> +               filename="r200_cp_microcode";
> +       else
> +               filename="radeon_cp_microcode";

As discussed before, the microcode should be versioned; it might be a
good idea to start right away, e.g. "r200_cp_microcode-0" etc.


> +		/* We assume the incoming data is in little-endian byte order,
> +		   since we would like the firmware file to be
> +		   architecture-independent.  Data will likely be swapped
> +		   twice on big-endian machines (once here, and
> +		   once in writel); with luck the compiler will optimize
> +		   that away. */

At least PPC CPUs simply use little endian load and store instructions.
:)


-- 
Earthling Michel Dänzer      |     Debian (powerpc), X and DRI developer
Libre software enthusiast    |   http://svcs.affero.net/rm.php?r=daenzer