Re: [Dri-devel] r200 color material enable fix / endgame

[Roland S. <rsc...@hi...>]

Michel D=C3=A4nzer wrote:
> On Thu, 2004-01-22 at 00:27, Roland Scheidegger wrote:
>=20
>>Keith Whitwell wrote:
>>
>>>Roland Scheidegger wrote:
>>>
>>>
>>>>--- r200_state.c    21 Jan 2004 16:08:43 -0000    1.9
>>>>+++ r200_state.c    21 Jan 2004 22:30:21 -0000
>>>>@@ -1695,7 +1734,7 @@
>>>>
>>>>    case GL_COLOR_MATERIAL:
>>>>       r200ColorMaterial( ctx, 0, 0 );
>>>>-      if (!state)
>>>>+      if ( state )
>>>>      r200UpdateMaterial( ctx );
>>>>       break;
>>>>
>>>
>>>How about just removing the test altogether?
>>
>>Tried that, doesn't work (same (or similar) errors as before). Strange,=
=20
>>that doesn't really make sense, or does it?
>=20
>=20
> No, and it works here; you did remove only the test, not the
> r200UpdateMaterial() call as well, right? :)
Right, I even rechecked it...
However, you're "suggestion" is interesting, removing the=20
r200UpdateMaterial() call there works too here (for endgame at least).=20
Removing only the state test does absolutely nothing for endgame (4.05=20
or 4.14) unfortunately for me.
Maybe we have different other patches attached? I'm using your=20
http://penguinppc.org/~daenzer/DRI/r200-attenuation-2.diff patch (and=20
also the texture compression stuff, but this can't make a difference here=
).
(I also have a RV250, not R200, but let's hope this doesn't make a=20
difference.)

Roland