Re: AMD 64 AGP Patch (Was Re: [Dri-devel] r200 in cvs broken?)

[Dave J. <da...@re...>]

On Wed, Nov 19, 2003 at 12:13:37PM -0800, James Jones wrote:
 > 
 > 
 > Ronny V. Vindenes wrote
 > 
 > >It looks like you'll add GARTS up to MAX_HAMMER_GARTS-1 then bomb if
 > >there is an MAX_HAMMER_GARTS'th GART.
 > > 
 > >
 > Yes, thanks for putting it more clearly Ronny.
 > 
 > Dave, try walking through the code with MAX_HAMMER_GARTS=2 and SMP 
 > enabled.  You should quickly see what we mean.  Even with 
 > MAX_HAMMER_GARTS=1 and SMP enabled (running SMP support on one 
 > processor) which was the case I was trying to explain, it should fail.

Now changed to your proposed change (i > MAX_HAMMER_GARTS)

Thanks again.
		
		Dave