From: Brian P. <br...@tu...> - 2003-06-03 23:38:47
|
Denis Oliver Kropp wrote: > Quoting Brian Paul (br...@tu...): > >>Denis Oliver Kropp wrote: >> >>>I think the DRI drivers should be moved into the dri/ directory >>>which itself should be in the drivers/ directory, because drivers/ >>>contains the public APIs of Mesa, e.g. OSMesa, fxMesa etc. >>>The dri/ directory will contain windowing system independent code >>>as a public interface to the DRI drivers. The DRI drivers won't be >>>used by applications directly. >>> >>>My suggestion: >>> >>> drivers/ >>> common/ - reusable driver code >>> and transform_dd/ files >>> x11/ - X11 (XMesa) driver >>> osmesa/ - OSMesa driver >>> swfbdev/ - software fbdev driver >>> windows/ >>> beos/ >>> ggi/ >>> glide/ - was FX driver >>> dos/ >>> dri/ - dri driver interface >>> common/ - reusable driver >>> code >>> radeon/ - DRI/fbdev driver >>> r200/ - DRI/fbdev driver >>> mga/ - DRI/fbdev driver >>> >> >>Where do you propose that the files currently in Mesa/src/dri/ (such >>as dri_glx.c, glxclient.h, etc) belong? src/dri-es/ is the place I >>was planning on. > > > dri_glx.c and glxclient.h are part of XFree86 GLX/DRI AFAIK, so I think > they belong into src/glx/. Last time I checked (I worked on this stuff back in November), the dri_glx.c and glxclient.h files were chopped/modified versions of what's in the XFree86/DRI tree made for the embedded subset project. That's why I was suggesting that they go into a dri-es/ directory. > MiniGLX doesn't need dri_glx.c or glxclient.h. > > Also, extra "-es" versions shouldn't be needed as drivers/dri/ won't get > that big and works for embedded and full driver builds. I belive that Keith put a lot of work into the radeon-es driver in order to reduce the code size for our client. Thus, I expected that code would live in a separate radeon-es/ directory. Keith? >>Also, I want to try to keep all source files as leaves in the tree. >>That is, a directory foo/ won't contain both files and subdirs; just >>one or the other. > > > What about this? > > dri/ - dri driver interface > api/ - public api > common/ - reusable driver code > radeon/ - DRI driver > r200/ - DRI driver > mga/ - DRI driver What's the "public api"? If you and Keith want a drivers/dri/ directory just to catagorize the DRI drivers in one place, I can live with that. -Brian |