From: Michel <mi...@da...> - 2003-04-28 17:27:02
|
On Mon, 2003-04-28 at 19:19, Ian Romanick wrote: > Michel Dänzer wrote: > > On Mon, 2003-04-28 at 18:39, Ian Romanick wrote: > > > >>I sent this on Friday, but it never made it to the list. The original > >>attachment was too big, and the message was never approved. In any > >>case, the is the patch that I am going to merge to the trunk on Tuesday > >>evening (2003-Apr-29) can be found at: > >> > >>http://www.cs.pdx.edu/~idr/texmem-merge-200304251121.tar.bz2 > >> > >>I think that everything is clean, but there are a couple things that > >>came up in the diff that look hinkey to me. > > > > > > [...] > > > > > >>2. The gen_int_cntl stuff in r128_driver.c > > > > The handling of this should probably be modeled after the trunk radeon > > driver. > > In the trunk, the R128 driver sets save->gen_int_cntl to 0 in > InitCommonRegisters. In the trunk (and the branch) the Radeon driver > doesn't set it at all in InitCommonRegisters. Right, because that would clobber it and disable interrupts on mode changes. > In the branch, the R128 driver sets it to 0 if XF86DRI is not defined, > and info->gen_int_cntl if it is. Hmm, sounds like the radeon driver should also set it to 0 under some circumstances. -- Earthling Michel Dänzer \ Debian (powerpc), XFree86 and DRI developer Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer |