Re: [Dri-devel] Double define for radeon data structures?

[Keith W. <ke...@tu...>]

David Dawes wrote:
> On Tue, Mar 11, 2003 at 05:47:20PM +0000, Keith Whitwell wrote:
> 
>>Guido Landra wrote:
>>
>>>  Hi all,
>>>This is my first post, be patient, please! :)
>>>
>>>I'm reading radeon code on CVS.
>>>In  radeon_drm.h, on kernel side,  I can see a lot of  data structures 
>>>already defined on client side in radeon_sarea.h.
>>>They are about shared area, but also about data types used by IOCTLs and 
>>>register defines.
>>>They have same data members but sometimes different names.
>>>
>>>Is there a specific need for this?
>>>Can I simply define everything in one file and import it in both kernel 
>>>and client components?
>>
>>It would be nice & easy, wouldn't it.  Unfortunately for us, XFree86 coding 
>>standards don't permit operating system files to be directly included in the 
>>drivers -- even when the portion of the operating system is being supplied by 
>>XFree86.
> 
> 
> The important point is that header files included in drivers be
> OS-independent.  If such things were put in shared/drm/kernel, and have
> no OS dependencies, then I don't see that there would be a problem.
> 
> BTW, this has nothing to do with a coding standard, but everything to
> do with the OS-independence of binary driver modules.

Fair enough - there's a desire to have os-independence and effectively that 
means you can't include os headers in driver code.  The shared/drm/kernel 
directory is a relatively new construct and it makes sense that those 
duplicated structs could now be defined just once there - I guess nobody 
picked up on this new opportunity to clean things up a bit - I certainly didn't...

Keith