Re: [Dri-devel] patch for function naming consistency

[Ian R. <id...@us...>]

Philip Brown wrote:
> On Wed, Mar 12, 2003 at 10:21:17PM +0100, Michel D=E4nzer wrote:
>
>>This change doesn't seem obvious to me; the RADEONDRIxxx() functions ar=
e
>>in radeon_dri.c and directly related to the DRI, whereas
>>RADEONPreInitDRI() (along with other RADEONPreInitxxx() functions) is i=
n
>>radeon_driver.c
>=20
> Maybe it belongs in radeon_dri.c, then? Coincidence of current location=
,
> should not be a reason for avoiding logical naming and grouping.
> If you like, I'll submit patches for doing the move AND rename.

[snip]

> So RADEONPreInitDRI() doesnt actually do any rendering; So what.
> It is still "DRI related".

I think Michel is saying that this name is more consistent because this=20
function groups more closely with the other RADEONPreInit functions than=20
with the other RADEONDRI functions.  I guess it's six of one,=20
half-a-dozen of the other...