Re: [Dri-devel] Setting close on exec for linux DRM (fixes many lockups)

[Elladan <el...@es...>]

This needs to be fixed in the drm kernel module, it's a security
issue...

-J

On Tue, Aug 20, 2002 at 09:56:03PM +0100, Tim Smith wrote:
> Attached is a patch which sets the FD_CLOEXEC flag on the filedescriptor 
> opened by the linux DRM. This fixes a number of X lockups in screensavers 
> and possibly elsewhere, where the DRI client forks and exec's another 
> process (e.g. the starwars screensaver). If the DRI client is killed while 
> it has the lock, the lock will never be released, because
> 
> 1. when the DRI client is killed the fd is still open, having been inherited 
> by a child and
> 2. when the child exits the current->pid is not the same as the process 
> holding the lock.
> 
> Can people who know about other platforms tell me if I'm breaking their 
> builds with this (I don't *think* I am, but I can't be 100% sure).
> 
> -- 
> Tim Smith (ti...@el...)
> "Dude." "Dude." "Dentist." "Dude."
>     - Conversation overheard between two eCos hackers