Re: [Dri-devel] Radeon problems with rendering into front buffer.

[Keith W. <ke...@tu...>]

Jacek Rosik wrote:
> 
> 
> Keith Whitwell wrote:
>  >>
>  >> And another strange thing after shading window:
>  >>
>  >> http://stud.ics.p.lodz.pl/~paproch/dri/shaded.jpg
>  >>
>  >> those sharks are moving. The same with glxgears and other apps.
>  >
>  >
>  > It looks like the 'zero cliprects' case doesn't work -- it keeps on
>  > using the last-set cliprect -- ie whatever's in hardware.  Previously
>  > you didn't see these droppings because they were never blitted to the
>  > front buffer.
>  >
>  > It shouldn't be too hard to fix.
>  >
>  > Keith
>  >
> 
> I've noticed you fixed this bug in r200 branch. Here's patch for trunk.

I'll apply this.

> I think we should also stop making page flips (swapping buffers) in case 
> of one GLX client or when all clients have 'zero cliprects'. I don't know
> how page flipping works with multiple GLX clients.

I don't understand this statement.  At the moment there are only pageflips 
when there is exactly one GLX client, regardless of how many cliprects it has. 
  We could add a test for zero cliprects & turn flip into a noop in that case.

Keith