Re: [Dri-devel] Bug in glxcmds.c

[Brian P. <br...@tu...>]

Johannes Rath wrote:
> It looks that in glxcmds.c in function glXChooseVisual before line 1015 one
> line is missing:
> __GLX_GCONF(GLX_TRANSPARENT_TYPE_EXT);
> otherwise transparentPixelValue gets compared to the number of auxiliary
> buffers, which makes absolutely no sense.

Good catch.

In my copy of glxcmds.c though, it was line 1017.  Here's the diff - does
it match what you expected?


diff -c -r1.26 glxcmds.c
*** glxcmds.c   12 Jun 2002 15:50:25 -0000      1.26
--- glxcmds.c   31 Jul 2002 13:54:47 -0000
***************
*** 1015,1020 ****
--- 1015,1021 ----
         else
             score += AuxScore(auxBuffers, val);
         if (transparentPixel) {
+           __GLX_GCONF(GLX_TRANSPARENT_TYPE_EXT);
             if (transparentPixelValue != val)
                 continue;
             if (transparentPixelValue == GLX_TRANSPARENT_TYPE_EXT) {


-Brian