Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

[Joaquin C. A. <e98...@ya...>]

--- "R. Reucher" <ren...@cp...> wrote:
> Andrew James Richardson wrote:
> 
> > Brian,
> > 
> >    I thought that in the C specs you can't be
> guarenteed the order of
> > evaluation in an if brace. Surely a safer bet is
> > 
> >         if(!image){
> >                 if(!image->Data){
> >                         ...
> >                 }
> >         }
> You're right here. But as as long as you only READ
> it should make no
> difference (IMHO)...

if it's right, it makes a big difference.  If you try:

if (!image->Data || !image)

the program will segfault trying to access the member
Data of a null pointer.

Though I think that the order evaluation IS specified
in the standard.

Cheers,

--
Joaquin Cuenca Abela
e98...@ya...


__________________________________________________
Do You Yahoo!?
Get personalized email addresses from Yahoo! Mail - only $35 
a year!  http://personal.mail.yahoo.com/