Re: [Dprobes] Re: Dprobe patches for 2.6.9

[Will C. <wc...@re...>]

Will Cohen wrote:
> Prasanna S Panchamukhi wrote:
> 
>> Hi Will,
>>
>> The patches avaliable on the kprobes website are for 2.6.9-final 
>> vanilla kernel.
>> You need to download the vanilla kernel from the kernel.org and then 
>> apply
>> the dprobes patches. Applying 2.6.9-final dprobes patches to FC2/FC3 
>> might not
>>  be appropriate. I have tested dprobes with HIGHMEM 4GB enabled on  
>> 2-way SMP i386 box and seems to have worked fine. Please apply the 
>> patches to the vanilla kernel version 2.6.9-final. Let me know if you 
>> have any issues.
>>
>> Thanks
>> Prasanna
> 
> 
> 
> The patch for i386 dprobes support breaks the kprobes for amd64. The 
> ainsn field of struct kprobe is still used in the x86_64. It appears 
> that the simplification to merge in the insn into struct kprobe isn't 
> going to hold for the x86_64. The x86_64 doesn't allow execution of data.
> 
> The arch_prepare_kprobe() in the x86_64 code allocates memory and could 
> potentially fail. The change in arch_prepare_kprobe() doesn't allow that 
> return value any more and assumes success.
> 
> I modified include/x86_64/kprobes.h, include/linux/kprobes.h, 
> kernel/kprobes.c and arch/i386/kernel/kprobes.c. I don't think my patch 
> is quite right; it ignores the return value of arch_prepare_kprobes().
> 
> -Will

Correct return type in function and typo in field. -Will