[Cuyahoga-devel] [JIRA] Resolved: (CUY-129) Bug in Core/Util/Globalization.cs

[Martijn B. (JIRA) <ji...@ti...>]

     [ http://tijnthuus.demon.nl:8080/jira/browse/CUY-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn Boland resolved CUY-129.
--------------------------------

    Resolution: Fixed

> Bug in Core/Util/Globalization.cs
> ---------------------------------
>
>                 Key: CUY-129
>                 URL: http://tijnthuus.demon.nl:8080/jira/browse/CUY-129
>             Project: Cuyahoga
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.5.0
>         Environment: Microsoft .NET Framework Version:2.0.50727.42; ASP.NET Version:2.0.50727.210 
>            Reporter: César González
>         Assigned To: Martijn Boland
>             Fix For: 1.5.1
>
>
> There is a bug in Core/Util/Globalization.cs. The method GetOrderedCultures insert duplicates key names in the orderedCultures SortedList, which causes, in same systems, the following error :
> Server Error in '/' Application.
> --------------------------------------------------------------------------------
> Item has already been added. Key in dictionary: 'Sami septentrional (Noruega)'  Key being added: 'Sami septentrional (Noruega)' 
> Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code. 
> Exception Details: System.ArgumentException: Item has already been added. Key in dictionary: 'Sami septentrional (Noruega)'  Key being added: 'Sami septentrional (Noruega)'
> Source Error: 
> Line 20: 			{
> Line 21: 				//if (!orderedCultures.ContainsKey(ci.DisplayName)) orderedCultures.Add(ci.DisplayName, ci.Name);
> Line 22:                 orderedCultures.Add(ci.DisplayName, ci.Name);
> Line 23: 			}
> Line 24: 			return (orderedCultures);
>  
> This could be easily fixed checking if the key exists before inserting :
> 		public static SortedList GetOrderedCultures()
> 		{
> 			SortedList orderedCultures = new SortedList();
> 			foreach (CultureInfo ci in CultureInfo.GetCultures(CultureTypes.SpecificCultures))
> 			{
> 				if (!orderedCultures.ContainsKey(ci.DisplayName)) orderedCultures.Add(ci.DisplayName, ci.Name);
> 			}
> 			return (orderedCultures);
> 		}
> Bye!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tijnthuus.demon.nl:8080/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira