#41 rgb parsing in function defect

[Sascha Broich]

When parsing an rgb value in a function the result gets defect. The commas will be treated as parameters:

Input: -webkit(rgb(18,52,86))
Output: -webkit(rgb(18,,,52,,,86))

Reparsing the output leads to a NullPointerExeption after the first comma.

In LexicalUnitImpl the function appendParams should be changed to take the comma-parameter in consideration:

private void appendParams(final StringBuilder sb, final LexicalUnit first) {
    LexicalUnit l = first;
    boolean comma = false;
    while (l != null) {
+      if (l.getLexicalUnitType()!=SAC_OPERATOR_COMMA) {
          if (comma) {
            sb.append(",");
          }
          comma = true;
          sb.append(l.toString());
+       }
        l = l.getNextLexicalUnit();
    }
}

[Sascha Broich]

• Description has changed:

Diff:

--- old
+++ new
@@ -11,8 +11,8 @@
         LexicalUnit l = first;
         boolean comma = false;
         while (l != null) {
----            if (comma) {
-+++            if (comma && l.getLexicalUnitType()!=SAC_OPERATOR_COMMA) {
+    ---    if (comma) {
+    +++    if (comma && l.getLexicalUnitType()!=SAC_OPERATOR_COMMA) {
                 sb.append(",");
             }
             comma = true;

[Sascha Broich]

• Description has changed:

Diff:

--- old
+++ new
@@ -11,12 +11,13 @@
         LexicalUnit l = first;
         boolean comma = false;
         while (l != null) {
-    ---    if (comma) {
-    +++    if (comma && l.getLexicalUnitType()!=SAC_OPERATOR_COMMA) {
+    +      if (l.getLexicalUnitType()!=SAC_OPERATOR_COMMA) {
+              if (comma) {
                 sb.append(",");
-            }
-            comma = true;
-            sb.append(l.toString());
+              }
+              comma = true;
+              sb.append(l.toString());
+    +       }
             l = l.getNextLexicalUnit();
         }
     }

[RBRi]

Fixed in SVN