From: Gisbert A. <gi...@we...> - 2007-03-12 12:10:10
|
Just had a look into Veto.java and can answer this question myself: Yes, this is how it works. It would be nice if Veto would write out something verbose into the log in debug mode like: "Stopping project foo from building because there are modifications in path-to-bar newer than the last successful build of bar according to path-to-bar's log. That would help to track down possible misconfigurations. -Gisbert Gisbert Amm wrote: > One step back: > > Is that the right way the veto builder should report that it's in action?: > > INFO | jvm 1 | 2007/03/12 11:53:32 | [cc]Mrz-12 11:53:31 > ThreadQueue - uncaugth exception in Thread-223 > INFO | jvm 1 | 2007/03/12 11:53:32 | > net.sourceforge.cruisecontrol.sourcecontrols.Veto$OutOfDateException: > buildstatus out of date compare > d to trigger changes > INFO | jvm 1 | 2007/03/12 11:53:32 | at > net.sourceforge.cruisecontrol.sourcecontrols.Veto.getModifications(Veto.java:34) > INFO | jvm 1 | 2007/03/12 11:53:32 | at > net.sourceforge.cruisecontrol.ModificationSet.getModifications(ModificationSet.java:199) > INFO | jvm 1 | 2007/03/12 11:53:32 | at > net.sourceforge.cruisecontrol.Project.getModifications(Project.java:404) > INFO | jvm 1 | 2007/03/12 11:53:32 | at > net.sourceforge.cruisecontrol.Project.build(Project.java:195) > INFO | jvm 1 | 2007/03/12 11:53:32 | at > net.sourceforge.cruisecontrol.Project.execute(Project.java:146) > INFO | jvm 1 | 2007/03/12 11:53:32 | at > net.sourceforge.cruisecontrol.ProjectConfig.execute(ProjectConfig.java:369) > INFO | jvm 1 | 2007/03/12 11:53:32 | at > net.sourceforge.cruisecontrol.ProjectWrapper.run(ProjectWrapper.java:69) > INFO | jvm 1 | 2007/03/12 11:53:32 | at > java.lang.Thread.run(Thread.java:595) > > Just to make sure we're talking about the same issue. > > -Gisbert > > Jeffrey Fredrick wrote: > >>Do the values you're giving the veto match what core has in its >>modificaiton set? If so, here's a question for you: does core >>_always_ build? >> >>Because all the veto is doing is polling to see if there are >>modifications returned, and if so it checks the dates. If it is >>saying there are always modifications for core then I'd expect core to >>always build, every single time. >> >>If core does always build, what is reported as the modifications? Are >>they real or are the externals always reported as modified even then >>they haven't? >> >>Jtf >> >>On 3/8/07, Gisbert Amm <gi...@we...> wrote: >> >> >>>The project my other projects depend on uses Subversion externals (an >>>external within another external in it, actually). Is it possible that >>>this prevents the veto builder from working correctly? When I activate >>>it, my dependent projects are never built; I always find the veto >>>exceptions in the log. Without the veto builder the projects build after >>>svn commit as expected. >>> >>>I use the veto builder within a project plugin like this: >>> >>><plugin name="project.kind.build.multiproject.dependent" >>>classname="net.sourceforge.cruisecontrol.ProjectConfig" >>>buildafterfailed="true"> >>>... >>><modificationset quietperiod="60" >>>ignoreFiles="${defaultignorefiles},${svnignorefiles}"> >>> <veto> >>> <triggers> >>> <svn LocalWorkingCopy="${tmpdir}/${dependency.svncheckoutdir}"/> >>> </triggers> >>> <buildstatus logdir="${logdir}/${dependency.project.name}" /> >>> </veto> >>> <svn LocalWorkingCopy="${tmpdir}/${svncheckoutdir}"/> >>> </modificationset> >>>... >>></plugin> >>> >>> >>>In the config.xml the plugin is used as follows: >>> >>>... >>><property name="logdir" value="${jbuild.home}/cruisecontrol/logs"/> >>><property name="tmpdir" value="${jbuild.home}/cruisecontrol/checkout"/> >>>... >>> >>><project.kind.build.multiproject.dependent name="dependent-project"> >>> <property name="svncheckoutdir" value="dependent-project/trunk"/> >>> <property name="dependency.project.name" value="core"/> >>> <property name="dependency.svncheckoutdir" value="core/trunk"/> >>> ... >>></project.kind.build.multiproject.dependent> >>> >>>Or am I doing something else wrong here? >>> >>>-Gisbert >>> >>>Jeffrey Fredrick wrote: >>> >>> >>>>I put a short write up of how and why to use the new veto source control: >>>> >>>>http://www.developertesting.com/archives/month200703/20070305-CruiseControl2.6.1Released.html >>>> >>>>http://tinyurl.com/2oyf2s >>>> >>>>If anyone has tried using it I'd be interested in hearing their experiences. >>>> >>>>Jtf >>>> >>> >> > -- Gisbert Amm Softwareentwickler Infrastruktur Telefon: (0721) 91374 - 4224 Telefax: (0721) 91374 - 2740 E-Mail: gis...@1u... Internet: www.1und1.de 1&1 Internet AG Elgendorfer Strasse 57 56410 Montabaur Amtsgericht Montabaur HRB 6484 Vorstand: Ralph Dommermuth, Matthias Ehrlich, Andreas Gauger (Vorsitzender), Matthias Greve, Hans-Henning Doerr, Henning Ahlert, Achim Weiss, Robert Hoffmann, Aufsichtsratsvorsitzender: Michael Scheeren |