RE: [Coriander-devel] Questions re Coriander Code

[Damien D. <d.d...@te...>]

On Thu, 2004-12-02 at 00:20, Jacob (Jack) Gryn wrote:
> b) I don't think a new video should be created unless the user specifies a
> new filename; as a result, I still believe it should (i) not be possible to
> change video modes while saving, or (ii) the save should be cancelled

We can have a switch in the preference to toggle between the two
behaviours...

> c) I can do more testing, I have not figured out what the conditions are
> that bring up that error.

Please try to reproduce it and let us know what you find... :-)

> d) there is a variable called save_service->fps which seems to store some
> sort of 'average' frame rate (# frames/current_time-prev_time).  This is
> nice for display purposes, but it doesn't tell me whether the user requested
> 15fps, 7.5fps, etc..  (the problem is that the first frame in a sequence
> always show 0.0 as the saving fps).  Where are the hard coded frame rates
> stored?

OK, I see. The IIDC framerates are coded in the camera struct:

camera->misc_info.framerate

The actual framerate for each service is estimated and put in
xxx_service->fps

Damien

> -----Original Message-----
> From: Damien Douxchamps [mailto:d.d...@te...] 
> Sent: Wednesday, December 01, 2004 6:12 AM
> To: Jacob (Jack) Gryn
> Subject: Re: [Coriander-devel] Questions re Coriander Code
> 
> Hello Jacob,
> 
> On Fri, 2004-11-26 at 06:54, Jacob (Jack) Gryn wrote:
> > While I was completing the updates for thread_save.c, I've come across
> > a few issues:
> > 
> >  
> > 
> > a)       When someone saves a video over a file that already exists,
> > there is no confirmation dialog box asking if I would like to
> > overwrite.  This should be added
> 
> This is a good idea indeed. -> todo
> 
> > b)       When a video is being saved, it should not be possible to
> > change the camera mode (it should be greyed out, or should end the
> > save if changed)
> 
> I'd say that if the video mode is changed a new video file should be
> created so that no frames are lost. What do you think?
> 
> > c)       When changing the "Options" in the Receive tab, I sometimes
> > see "Bad Bayer Path ID", some other options mess up the colours of the
> > video
> 
> Do you have more info about this? "Bad bayer pattern ID" should
> certainly not happen so we have to fix this.
> 
> > d)       Question: Is the REQUESTING framerate stored in a variable
> > somewhere?  (i.e., 15fps, 7.5fps; instead of the fps of the more
> > recent frame)
> 
> There is no framerate associated to each frame. The framerate is fixed
> for an ISO stream and does not change in time unless the user selects
> another value. (maybe I did not understand the question...)
> 
> > e)       Question: When doing an fwrite(), why is the parameter order
> > fwrite(buffer, 1, size, fp)  --- this actually writes size blocks of 1
> > byte, when instead it should be fwrite(buffer,size,1,fp) which writes
> > 1 block of size 'size'.
> 
> Good point here -> todo
> 
> I will fix all this when I have a camera to test the changes (see the
> patch status post sent earlier today)
> 
> Thanks for the good remarks! :-)
> 
> Damien
-- 
  _    Damien Douxchamps
 ('-   PhD Student / Research Assistant
 //\   Image Processing Group, Communications Lab, UCL, Belgium
 V_/_  http://www.tele.ucl.ac.be/view-people.php?id=46