Re: [Columba-devel] Refactoring of the filter stuff

[Frederik D. <fd...@co...>]

Hi Matthias,

in some cases we have to restructure the code a bit to remove dependencies
from the  configuration where appropriate. In the TagManager it doesn't make
much sense as its only a configuration thingy anyways.

I'll be in Mannheim next week from Monday to Thursday. So, let me know when
you are around and we have a coffee or beer - depending on the time we meet
;-)

Cheers,
-Frederik

On 11/21/06, Matthias Hub <sf...@ma...> wrote:
>
> Hi Freddy,
>
> Okay, I will see, where it is possible not to use the Config. I used
> Config, because the TagManager uses the Config, so there is the dependency.
> What do you think in this case, how to handle that in a consistent way?
>
> Btw: in the second half of next week I will be one day in Mannheim. Will
> you be there at that time?
>
> Greets,
> Matthias
>
> > Hi Matthias,
> >
> > I've also checked-in a few fixes in the tests to make it compile
> cleanly.
> >
> > @Matthias: I know that we use the Config() class quite often for testing
> > purposes (mostly "integration" tests). But, for unit tests we should try
> to
> > test things as local as possible. You should ask yourself if you really
> need
> > a configuration to test your funtionality. For example: Do you need to
> test
> > if the virtual folder works? No! Because its already proven by a
> specific
> > test for the virtual folder (that was just an example).
> >
> > Lets try together to drive this testing a bit more in the future. In the
> > Jira issue tracker, if even added an item which says "add easymock mock
> > objects junit extension", which makes testing things even easier.
> >
> > Hope I can give you a few more examples this week how this can be used.
> >
> > Best regards,
> > -Frederik
> >
> > On 11/20/06, Matthias Hub <sf...@ma...> wrote:
> > >
> > > Hi,
> > >
> > > > > just seen it, and looks fine for the compile time! I just got an
> > > Search Exception, when I started Columba again, which usually did not
> > > happen. I will have a closer look.
> > > > > Thanks for the hint, I'll do! (This evening I will not have
> internet
> > > access, but can work locally on my laptop. So the check-in will follow
> > > tomorrow.)
> > > > Thanks ;-) ... I will also make some more tests and start to work on
> > > the  mail-core stuff.
> > >
> > > Ok cool. I just checked in code, the only I removed the hard-coded
> > > directory link, pls check if this works for you now, thanks!
> > > Config c = new Config(new File(""));
> > >
>
> ---
> This mail was sent with the Java email client Columba. Read more at
> http://columbamail.org
>
>
>