Re: [Columba-devel] cvs head refactoring

[Mark L. <mli...@us...>]

On Tue, 27 Jun 2006 21:37:39 +0200 Frederik Dietz <fd...@co...> wrote:

> > I have just downloaded Eclipse 3.2M7 and am using this exercise to get used to it. While it is happy to complain about files, it does not yet appear to have refactoring built in so it is all manual fix jobs. It also doesn't appear to have a Generate Javadocs entry in the menus yet either :-( Just as well we have one in build.xml
> 
> That's sounds horribly. Is this a bug or missing feature of this milestone. I can't live with these features. Personally, I'm using the latest stable version for Columba.

I think we can safely say it is a milestone problem as they are somewhat fundamental functions!

Later - Javadocs are handled as a File -> Export menu entry

I got to the first "... needs unchecked conversion..."

Before

	/**
	 * processCalendarEvents method
	 */
	public void processCalendarEvents() {
		if (itemAddedList[swap].size() > 0) {
			LOG.info("process item added calendar events");
			Collections.sort(itemAddedList[swap], StoreEventComparator.getInstance());

After

	/**
	 * processCalendarEvents method
	 */
	public void processCalendarEvents() {
		StoreEventComparator instance2 = StoreEventComparator.getInstance();
		StoreEventComparator storeEventComparator = instance2;
		StoreEventComparator storeEventComparator2 = storeEventComparator;
		List list = itemAddedList[swap];
		if (list.size() > 0) {
			LOG.info("process item added calendar events");
			Collections.sort(list, storeEventComparator2);

Whereupon it suggests for the last line to use a @SupressWarning :-(

Do you think we should just use @SupressWarning from the start and be done with it?! Maybe Freddy knows better Java than Sun ;-D

MarkL