Re: [coLinux-devel] Modified patch to run kernel 2.6.12 on colinux

[Henry N. <Henry.Ne@Arcor.de>]

Hello Yoshi,

Yoshiaki Tamura wrote:
> Hello colinux developpers,
> 
> Tha patch file for the linux kernel in the development snapshot package
> 2005/05/24 on the web is currently applicable to kernel 2.6.11.
> I modified this patch for kernel 2.6.12, 
> and you can download at the following address.
> 
> http://sourceforge.net/tracker/index.php?func=detail&aid=1245072&group_id=98788&atid=622065
> 
> Try this patch if you want to run kernel 2.6.12 on your colinux.

thanks for patch. :-)

I have tested this patch with kernel 2.6.12 and 2.6.12.4, both works
fine. It passed all my tests for "writev" and "check_rlimit" positive.

I can only not verify the hack in file mm/filemap.c (near line 1990) for
function generic_file_buffered_write.
Should access_ok with "bytes" or "maxlen"?

>>> linux-2.4.12.4/mm/filemap.c:1986 >>>
	maxlen = cur_iov->iov_len - iov_base;
	if (maxlen > bytes)
		maxlen = bytes;

	if (access_ok(VERIFY_READ, buf, bytes)) {
		fault_in_pages_readable(buf, maxlen);
	}

	page = __grab_cache_page(mapping,index,&cached_page,&lru_pvec);
<<< end cat <<<

Please verify this with kernel 2.4.11:
>>> linux-2.4.11/mm/filemap.c:1961 >>>
	if (access_ok(VERIFY_READ, buf, bytes)) {
		fault_in_pages_readable(buf, bytes);
	}

	page = __grab_cache_page(mapping,index,&cached_page,&lru_pvec);
<<< end cat <<<

-- 
Henry Nestler