Re: [coLinux-devel] Problems with latest monotone (cofs related)

[Dan A. <da...@co...>]

On Sat, Oct 23, 2004 at 07:20:44PM +0200, Dan Aloni wrote:
> On Sat, Oct 23, 2004 at 09:24:22AM -0400, Ian Bonnycastle wrote:
> > Ok, I tried out the latest monotone... and it compiles great (after I
> > figured out the little nuances with the build-all.sh script :) ).
> 
> What nuances? Send a patch.
> 
> > Anyways, I'm trying out cofs, and I get it mounted perfectly, but
> > access to it is only via the root user, even if I use the uid and gid
> > parameters in the mount. In fact, the files even show up as
> > readable/writeable by myself (when I used my username in the uid=
> > mount parameter), but every time I try to ls -l the /mnt directory
> > (where I mounted it), I get:
> > 
> > rehahno-ibonny % ls -l /mnt
> > ls: /mnt: Permission denied
> > 
> > and from df:
> > 
> > rehahno-ibonny % df -k
> > Filesystem           1K-blocks      Used Available Use% Mounted on
> > /dev/cobd0             2097084   1409644    687440  68% /
> > tmpfs                     6440         0      6440   0% /dev/shm
> > df: `/mnt': Input/output error
> >
> > 
> > Anyone seen this before? When I access it as root, I have full access,
> > and everything works perfectly. The thing is, I'm never on my system
> > as the root user (I use sudo all the time).
> 
> The df issue got fixed today. However, I haven't fixed the code
> that sets the permissions for root of the mount, so this could 
> explain the problem with 'ls -l /mnt'.
> 
> Unfortunately, I already started uploading 0.6.2-pre5 when I 
> started reading your E-Mail, so expect a fix shortly in -pre6.  

This patch should fix the permission problem in the meanwhile.

diff -u b/fs/cofusefs/inode.c b/fs/cofusefs/inode.c
--- b/fs/cofusefs/inode.c
+++ b/fs/cofusefs/inode.c
@@ -489,6 +489,8 @@
 		return ERR_PTR(-EINVAL);
 
 	md.rootmode = S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO;
+	md.uid = co_md.uid;
+	md.flags = FUSE_ALLOW_OTHER | FUSE_DEFAULT_PERMISSIONS;
 
 	co_md.fuse = &md;
 	snprintf(co_md.name, sizeof(co_md.name), "%s", dev_name);


-- 
Dan Aloni
da...@co...