Re: [coLinux-devel] offset calculation breakage

[Vladislav G. <the...@ma...>]

Dear Henry,

> OK. That give the test result:
> 10 5 10 10
> 
> Is the "MEMBER + const" right in usage of that macro?
> Or is that a side effect in calculation?

It's right only within braces but the logic isn't good due non clear struct
pointer arithmetics.
Your committed variant seems to be more readable and fixes my issue, of
course.

Thank you and
Best Regards, theMIROn
ICQ: 303357
Skype: the.miron

> -----Original Message-----
> From: Henry Nestler [mailto:hen...@ar...]
> Sent: Tuesday, January 11, 2011 5:01 AM
> To: Vladislav Grishenko
> Cc: col...@li...
> Subject: Re: [coLinux-devel] offset calculation breakage
> 
> Hello Vladislav,
> 
> On 11.01.2011 00:13, Vladislav Grishenko wrote:
> > Dear Henry,
> > Sure it was't work the way you wrote
> >> #define co_offsetof(TYPE, MEMBER) ((int)&((TYPE *)0)->MEMBER)
> > But proposed define had member-whatever-it-contains bracket escaping
> >> #define co_offsetof(TYPE, MEMBER) ((int) (&((TYPE *)0)->MEMBER))
> > So, with MEMBER == field+const it will be equal to start_of_field +
> > const*size_of_filed
> 
> OK. That give the test result:
> 10 5 10 10
> 
> Is the "MEMBER + const" right in usage of that macro?
> Or is that a side effect in calculation?
> 
> > Anyway, I'd like to see it fixed in svn :) Btw, there's a lot of
> > places with old style calculations, I mean without co_offsetof usage,
> > even right several lines below the discussing line.
> 
> I only changed that line in revision 1560, because the GCC 4.4.1 under
Linux
> as host has a warning.
> If you have more such changes, be welcome.
> 
> --
> Henry N.
> 
> 
>
----------------------------------------------------------------------------
--
> Gaining the trust of online customers is vital for the success of any
company
> that requires sensitive data to be transmitted over the Web.   Learn how
to
> best implement a security strategy that keeps consumers' information
> secure
> and instills the confidence they need to proceed with transactions.
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> coLinux-devel mailing list
> coL...@li...
> https://lists.sourceforge.net/lists/listinfo/colinux-devel