Menu

#125 Nassi Shneiderman Plugin: Enhancement to the Cparser

Next_Nightly
fixed
danselmi
None
2016-01-30
2015-01-04
scarphin
No

This patch enhances the Cparser to parse more comments.

1 Attachments

Discussion

  • Teodor Petrov

    Teodor Petrov - 2015-01-07
    1. move_comment should be MoveComment.
    2. There is no point in declaring move_comment in the header as far as I can see.
    3. I can say much about the other changes, because I have no idea how it works... but I can see it is some complex use of some complex boost lib:)
     
    • scarphin

      scarphin - 2015-01-07
      1. Original author's coding style but I changed it to 'MoveComment' per your request. New patch attached.
      2. I didn't get that. What header file?
      3. Yeah, it's a very complex library but the usage is quite simple. You can check the link below for some documentation.
        http://www.boost.org/doc/libs/1_57_0/libs/spirit/doc/html/spirit/qi/tutorials.html
       
  • Teodor Petrov

    Teodor Petrov - 2015-01-08
    1. Unfortunately the files in contrib doesn't follow the coding style, but this should be fixed...
    2. There is no point declaring the class in the header, you can declare it in the cpp file. It is only used there.
    3. I have no intention, I try to be as far away from boost as possible.
     
  • danselmi

    danselmi - 2015-01-15
    • status: open --> fixed
    • assigned_to: danselmi
    • Milestone: Next Release --> Next Nightly

    Applied in head

     

    Last edit: danselmi 2015-01-15
  • Teodor Petrov

    Teodor Petrov - 2015-01-17

    Danselmi: Have you fixed the problems I've mentioned?

     
    • scarphin

      scarphin - 2015-01-19

      1 & 2. Check line 71 in 'CParser.cpp'.

       

Log in to post a comment.