Re: [CLucene-dev] First part of UTF-8 patch

[David R. <dav...@ya...>]

--- Ben van Klinken <be...@vi...> wrote:
> Grrk,
> How embarrasing...
> 
> i think i won't say anymore for now

Well, let's consider some evidence from the text of Ben's original
e-mail:
> > > On 2004-04-20 at 04:32, Ben van Klinken wrote:
> > > ...
> > > i'm really stoked!
> > > ...

Okay, so twelve minutes after 4:20 on 4/20, Ben describes himself as
"really stoked".  I think it's obvious how embarrassing lapses of
rationality could arise under such extenuating circumstances ;)

> > > Just a few comments:
> > > DSR: It is correct not to delete this->reader. 
> > > - not sure what you mean, butthe reader is usually cleaned 
> > > up by the indexer somewhere

Yes, that note was intended to document for future memleak hunters that
this->reader was accounted for.  There's a similar note in
FuzzyTermEnum::~FuzzyTermEnum; I hope they'll be preserved.

> > > LLONG_MAX: is too long, i think LONG_MAX is the longest a 
> > > date will ever need to be

Possibly, but the DateField::stringToTime returns a long_t, which is
currently defined in LuceneWindows.h and LuceneUnix.h as a 64-bit
integer.  Does it really make sense to allow DateField::stringToTime to
return a value larger than DateField::MAX_TIME?

> > > lltoa/lltow: i think only available mingw32?

Upon further investigation, I guess you're right.  I thought lltoa and
lltow were part of the C standard, but apparently not.

> > > looking forward to your python... patches!

As I said a few weeks ago, my work on the Python binding has been
preempted by a client project.  It'll be a few weeks before I can
address it again.

That binding will definitely be open source (LGPL, because CLucene uses
LGPL), but I haven't decided whether to seek its inclusion in the
official distribution of CLucene.  I'm planning to use the binding in
an extensive and demanding manner, so I must reserve the right to
change it radically and backward-incompatibly, at least early in its
life.

> > > would you like me to put you onto the developer list? i think 
> > > you deserve it.

Yes, please.


	
		
__________________________________
Do you Yahoo!?
Yahoo! Photos: High-quality 4x6 digital prints for 25¢
http://photos.yahoo.com/ph/print_splash