Re: [CLucene-dev] IndexModifier exception during destruction

[Itamar Syn-H. <it...@di...>]

Would love one, thanks.

Itamar. 

> -----Original Message-----
> From: Kostka Bořivoj [mailto:ko...@to...] 
> Sent: Wednesday, June 16, 2010 6:49 PM
> To: clu...@li...
> Subject: Re: [CLucene-dev] IndexModifier exception during destruction
> 
> Thanks. You can reproduce this if you try to call addDocument 
> on locked index.
> If you wish, I'll try to write simple test which reproduces the bug
> 
> Borek
> 
> > -----Original Message-----
> > From: Itamar Syn-Hershko [mailto:it...@di...]
> > Sent: Wednesday, June 16, 2010 5:11 PM
> > To: clu...@li...
> > Subject: Re: [CLucene-dev] IndexModifier exception during 
> destruction
> > 
> > You are right, thanks. This is how JL does this too. I 
> fixed this and 
> > committed to git as e75f0c...22e4 [1].
> > 
> > Do you have a way of reproducing this, so we can add a test case to 
> > our test suite?
> > 
> > By the way, we no longer maintain 0.9.21 or the SVN repository, so 
> > you'll need to either pull this specific patch or use the 
> git master 
> > for development. See: http://clucene.sourceforge.net/download.shtml.
> > 
> > Itamar.
> > 
> > [1]
> > 
> http://clucene.git.sourceforge.net/git/gitweb.cgi?p=clucene/clucene;a=
> > commit
> > diff;h=e75f0cf7c005ce76b1c683a19a1b849c323a22e4
> > 
> > > -----Original Message-----
> > > From: Kostka Bořivoj [mailto:ko...@to...]
> > > Sent: Wednesday, June 16, 2010 12:08 PM
> > > To: clu...@li...
> > > Subject: [CLucene-dev] IndexModifier exception during destruction
> > >
> > > After an unsuccesfull call of IndexModifier::addDocument (catched 
> > > exception "Lock obtain timed out"), IndexModifier 
> destructor causes 
> > > Accesss violation exception.
> > >
> > > This is beacause after unsuccessfull call to addDocument both 
> > > members indexReader and indexWriter are NULL, but the check of 
> > > indexReader is missing in IndexModifier::close() method (which is 
> > > called from destructor):
> > >
> > > void IndexModifier::close() {
> > > 	SCOPED_LOCK_MUTEX(directory->THIS_LOCK)
> > > 	if (indexWriter != NULL) {
> > > 		indexWriter->close();
> > > 		_CLDELETE(indexWriter);
> > > 	} else {					<<<<<<<
> > > Missing: if (indexReader != NULL)
> > > 		indexReader->close();
> > > 		_CLDELETE(indexReader);
> > > 	}
> > > 	_CLDECDELETE(directory)
> > > 	open = false;
> > > }
> > >
> > > Clucene 0.9.21 on Win XP and MS VC 2005 used
> > >
> > >
> > >
> > > --------------------------------------------------------------
> > > ----------------
> > > ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad 
> > > Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky 
> parental unit.  
> > > See the prize list and enter to win:
> > > http://p.sf.net/sfu/thinkgeek-promo
> > > _______________________________________________
> > > CLucene-developers mailing list
> > > CLu...@li...
> > > https://lists.sourceforge.net/lists/listinfo/clucene-developers
> > >
> > 
> > 
> > 
> > 
> ----------------------------------------------------------------------
> > -------- ThinkGeek and WIRED's GeekDad team up for the Ultimate 
> > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
> lucky parental 
> > unit.  See the prize list and enter to win:
> > http://p.sf.net/sfu/thinkgeek-promo
> > _______________________________________________
> > CLucene-developers mailing list
> > CLu...@li...
> > https://lists.sourceforge.net/lists/listinfo/clucene-developers
> 
> --------------------------------------------------------------
> ----------------
> ThinkGeek and WIRED's GeekDad team up for the Ultimate 
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky 
> parental unit.  See the prize list and enter to win: 
> http://p.sf.net/sfu/thinkgeek-promo
> _______________________________________________
> CLucene-developers mailing list
> CLu...@li...
> https://lists.sourceforge.net/lists/listinfo/clucene-developers
>