From: Isidor Z. <cl...@qu...> - 2009-05-31 08:34:58
|
> However, I do wonder if the > existing code can be easily changed to allow the rewrite() methods to > delete the original query when creating a new one. Most notably, this would require to always copy the query before rewriting inside Searchable::_search. Otherwise users will probably be surprised that the query passed to Searcher::search is deleted. I think this is neither an extremely clean solution. I wouldn't be surprised if improving this situation would require more intrusive changes. Looks like the current protocol involving pointer comparisons to detect the need for deletion is followed consistently, so until a solution with enough advantages to justify large changes is found, having it nicely documented might be the best option. Best regards, Isidor |