Re: compute-system-path needs a call to string to accept keywords for module-name.

[Marco A. <ma...@cs...>]

Thanks for the report.  It was fixed in 1.67.

However, on the side, I have noted that there is an abuse of keywords 
in the CL practice for things like this (and package naming).  My 
diagnosis goes back to THE BIG MISTAKE (with the power of hindsight :) 
) made when CL was made uppercase default, and to the kludgy and non 
backward compatible hack by Franz.  Using strings is not a bad idea, 
especially when you need to name things that eventually become part of 
a pathname.

Cheers

marco



On Tuesday, Feb 10, 2004, at 04:11 America/New_York, Pascal 
J.Bourguignon wrote:

>
> While compiling lisa, I get this error:
> *** - MAKE-PATHNAME: illegal :DIRECTORY argument (:RELATIVE :LISA)
>
> which occurs in defsystem-3.x/defsystem.lisp (cvs 1.66):
>
> (defun compute-system-path (module-name definition-pname)
>   (let* ((file-pathname
> 	  (make-pathname :name (etypecase module-name
> 				 (symbol (string-downcase
> 					  (string module-name)))
> 				 (string module-name))
> 			 :type *system-extension*))
>          (lib-file-pathname
> 	  (make-pathname :directory (list :relative module-name) ;;<--- here
>                          :name (etypecase module-name
> 				 (symbol (string-downcase
> 					  (string module-name)))
> 				 (string module-name))
> 			 :type *system-extension*))
>          )
>
> valid pathname directory  n. a string, a list  of strings, nil, :wild,
> :unspecific, or some other object  defined by the implementation to be
> a valid directory component.
>
>
> It  seems that  module-names  are expected  to  possibly be  keywords,
> therefore I'd suggest to use string here:
>
> <	  (make-pathname :directory (list :relative module-name) ;;<--- here
>> 	  (make-pathname :directory (list :relative (string module-name))
>
>
> -- 
> __Pascal_Bourguignon__                     
> http://www.informatimago.com/
> There is no worse tyranny than to force a man to pay for what he 
> doesn't
> want merely because you think it would be good for him.--Robert 
> Heinlein
> http://www.theadvocates.org/
>
>
> -------------------------------------------------------
> The SF.Net email is sponsored by EclipseCon 2004
> Premiere Conference on Open Tools Development and Integration
> See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
> http://www.eclipsecon.org/osdn
> _______________________________________________
> clocc-list mailing list
> clo...@li...
> https://lists.sourceforge.net/lists/listinfo/clocc-list
>
--
Marco Antoniotti					http://bioinformatics.nyu.edu
NYU Courant Bioinformatics Group		tel. +1 - 212 - 998 3488
715 Broadway 10th FL				fax. +1 - 212 - 998 3484
New York, NY, 10003, U.S.A.