From: Ram K. <rk...@kr...> - 2003-04-04 23:37:31
|
On Friday, April 4, 2003, at 03:28 PM, Sam Steingold wrote: >> * In message <A88...@kr...> >> * On the subject of "Re: patches to CLOCC-PORT" >> * Sent on Fri, 4 Apr 2003 15:10:42 -0800 >> * Honorable Ram Krishnan <rk...@kr...> writes: >> >> Because I was working in SCL and OpenMCL more or less concurrently, >> the following diff has a mix of modifications for both. > > 1. please keep the features checks in alphabetical order, i.e., > #+allegro > #+clisp > #+cmucl > #+lispworks > #+openmcl > #+sbcl > #+scl Sure. How about cases where the code for the CMUCL and SCL ports are the same? I've been using #+(or cmu scl) to cover those. > 2. please do not use #\Tab characters. Done. >> Also, I've contacted the maintainer of SCL about reviewing some of >> these changes so there may be improvements that he may suggest in the >> future. > > maybe you could submit the final patch after they get back to you? They gave me the okay on these changes so we're set. -ram |