Re: [clisp-list] build from cvs as of 2009-8-17 (related to ebadf)

[Sam S. <sd...@gn...>]

Don Cohen wrote:
> Sam Steingold writes:
> 
>  > One tiny tweak won't hurt though:
>  > 
>  > --- package.d.~1.136.~	2009-11-13 09:40:45.000000000 -0500
>  > +++ package.d	2010-02-17 13:22:59.000737000 -0500
>  > @@ -3009,10 +3009,9 @@ LISPFUNN(package_iterate,1) {
>  >                   shadowing-list of pack),
>  >                2. itself not already present in pack (because in this case
>  >                   the accessibility would be :INTERNAL or :EXTERNAL). */
>  > -          var object shadowingsym;
>  >             if (!(eq(Car(PIS(state,FLAGS)),S(Kinherited))
>  >                   && (shadowing_lookup(Symbol_name(value2),false,
>  > -                                     PIS(state,PACK),&shadowingsym)
>  > +                                     PIS(state,PACK),NULL)
>  >                       || symtab_find(value2,
>  >                                      ThePackage(PIS(state,PACK))->
>  >                                      pack_internal_symbols)
>  > 
>  > try applying this to the broken clisp and see if it fixes it.
> 
> The code I see doesn't seem to quite correspond to yours:
>              2. itself not already present in pack (because in this case 
>                 the accessibility would be :INTERNAL or :EXTERNAL). */
>           { 
>             var object shadowingsym; 
> [I guess you want to delete the line above]
>             if (!(eq(Car(TheSvector(state)->data[5]),S(Kinherited)) 
>                   && (shadowing_lookup(Symbol_name(value2),false, 
>                                        TheSvector(state)->data[4], 
>                                        &shadowingsym) 
> [I guess you want to change the line above to "NULL)"]
>                       || symtab_find(value2, 
>                                      ThePackage(TheSvector(state)->data[4])-> 
>                                      pack_internal_symbols) 
>                       || symtab_find(value2, 
>                                      ThePackage(TheSvector(state)->data[4])-> 
>                                      pack_external_symbols)))) { 
>               /* Symbol value2 is really accessible. */ 
> 
> Is that correct?

yes.

> You did look at 1.121, right?  This seems to be unrelated to it.

1.121 made shadowing_lookup into a macro from a function.