From: John H. <hi...@al...> - 2009-06-18 17:56:57
|
Can it wait a few days until I am over the swine flu? :( At first look I like these changes and think they will be helpful. The FastCGI module was a first project for me w/ CLips a LONG time ago so I'll be not surprised if there are issues. On Thu, Jun 18, 2009 at 01:33:36PM -0400, Sam Steingold wrote: > Hi Tom, > > Tom Weissmann wrote: > > > >I would like to propose some additional functions for the fastcgi > >module, to enable reading and writing to fastcgi stdin, stdout, and > >stderr using octets. These functions use arrays of bytes and do no > >conversion, which is an advantage is some situations: > > > >- reading binary attachments, in chunks if they are large > >- serving binary files like images > >- creating a binary stream interface - eg if you want to use > >flexi-streams to handle character encoding. > > > >The proposed changes can be found here: > >http://tom.schutzer-weissmann.net/2009/06/binary-io-for-clisps-fastcgi-module/. > > thanks! > John, could you please take a look at this code? > > >As may be obvious, this is the first time I've tried contributing to > >Clisp. > > welcome! > > All code distributed with clisp is covered by the GNU GPL v2 or any later > version at the user's (i.e., Joe Random's who has just downloaded clisp) > discretion. > > Do you agree with these terms? > > >If I'm doing it wrong please tell me. > > Please provide the unified diffs instead of the plain ones. > I have this in my ~/.cvsrc: > ====================================== > cvs -q -z9 > diff -uwp -F^(def > update -dP > ====================================== > I think these are good defaults. |