[ clisp-Bugs-1924501 ] clisp-2.44.1/src/lispbibl.d", line 1210: cannot find include

[SourceForge.net <no...@so...>]

Bugs item #1924501, was opened at 2008-03-24 17:29
Message generated for change (Comment added) made by vvv2
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101355&aid=1924501&group_id=1355

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: clisp
Group: build problems
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Vladimir Volovich (vvv2)
Assigned to: Sam Steingold (sds)
Summary: clisp-2.44.1/src/lispbibl.d", line 1210: cannot find include

Initial Comment:
when building clisp-2.44.1 on Sparc Solaris 2.8 using Sun Studio 11 compiler, i get an error:

[...]
rm -f spvw_calendar.c
ln -s /opt/home/vvv/src/clisp/clisp-2.44.1/src/spvw_calendar.c spvw_calendar.c
rm -f localcharset.h
ln -s /opt/home/vvv/src/clisp/clisp-2.44.1/src/gllib/localcharset.h localcharset.h
cc -I/opt/home/vvv/src/inst/include -dalign -fsingle -DUNIX_BINARY_DISTRIB -DUNICODE -DDYNAMIC_FFI -DNO_GETTEXT -I. -c spvw.c
"/opt/home/vvv/src/clisp/clisp-2.44.1/src/lispbibl.d", line 1210: cannot find include file: <stdbool.h>
[...]

CFLAGS in the generated Makefile does not appear to have -Igllib:

$ grep '^CFLAGS ' Makefile
CFLAGS =  -dalign -fsingle -DUNIX_BINARY_DISTRIB -DUNICODE -DDYNAMIC_FFI -DNO_GETTEXT -I.

If i edit Makefile and change CFLAGS to

CFLAGS =  -dalign -fsingle -DUNIX_BINARY_DISTRIB -DUNICODE -DDYNAMIC_FFI -DNO_GETTEXT -I. -Igllib

the build proceeds further.


----------------------------------------------------------------------

>Comment By: Vladimir Volovich (vvv2)
Date: 2008-03-24 22:45

Message:
Logged In: YES 
user_id=1804953
Originator: YES

yes, line 643 contains
CFLAGS=${CFLAGS}' -Igllib'

but then line 1243 sets

XCFLAGS=''

some further code adds data to XCFLAGS, until it becomes
-dalign -fsingle -DUNIX_BINARY_DISTRIB -DUNICODE -DDYNAMIC_FFI
-DNO_GETTEXT -I.

and finally, line 1951 outputs whatever is currently in XCFLAGS:

echol "CFLAGS = ${XCFLAGS}"

thus, initial assignment to CFLAGS which happened prior to line 1243, are
lost.

line 1243 attempts to remove optimization options (and also looses the
-Igllib which happens to occur before it).
but i pass to CFLAGS not only optimization flags but architecture flags,
i.e. -xarch=v8
so clearing CFLAGS in this way is not good.

Better document that users should not use optimization flags on sun
compiler, but do not clear CFLAGS altogether,
which may contain other options. Then i'll be able to pass
CFLAGS="-xarch=v8".

Configure script may issue an error or a warning at the line 1243 if it
detects that CFLAGS specified by user contains "-O" string,
but please allow to use other flags and do not clear them.

Best,
v.


----------------------------------------------------------------------

Comment By: Sam Steingold (sds)
Date: 2008-03-24 19:14

Message:
Logged In: YES 
user_id=5735
Originator: NO

do you see

# for systems that lack stdint (or have a broken stdin) [e.g., solaris9]
CFLAGS=${CFLAGS}' -Igllib'

around lines 642/643 in src/makemake.in?

----------------------------------------------------------------------

Comment By: Vladimir Volovich (vvv2)
Date: 2008-03-24 19:08

Message:
Logged In: YES 
user_id=1804953
Originator: YES

i verified with just-updated CVS tree, and the same error is still
present:

ln -s /opt/home/vvv/src/clisp/clisp/src/gllib/localcharset.h
localcharset.h
cc -I/opt/home/vvv/src/inst/include -dalign -fsingle -DUNIX_BINARY_DISTRIB
-DUNICODE -DDYNAMIC_FFI -DNO_GETTEXT -I. -c spvw.c
"/opt/home/vvv/src/clisp/clisp/src/lispbibl.d", line 1214: cannot find
include file: <stdbool.h>


----------------------------------------------------------------------

Comment By: Sam Steingold (sds)
Date: 2008-03-24 18:09

Message:
Logged In: YES 
user_id=5735
Originator: NO

I think this has been fixed in the cvs head.
could you please verify?
thanks

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101355&aid=1924501&group_id=1355