From: Bruno H. <br...@cl...> - 2004-01-12 19:24:04
|
Hi Sam, > could you please clarify the rationale behind your recent eval.d patch? > Specifically, > > - why did you restore the -fomit-frame-pointer trick? > we discussed that and you approved removing this option. I did not restore -fomit-frame-pointer. You eliminated -fomit-frame-pointer from makemake.in, but a user who thinks he's clever might add it to the CFLAGS nevertheless. I restored the _protection_ against -fomit-frame-pointer generating buggy code for interpret_bytecode_, after I verified that even with the newest GCCs, it has the desired effect. > - why did you remove the parse_dd() variable? > we discussed that and you said that you agree that instead of > referring to STACK directly we should use named variables instead. > this is not too important though, this variable was used just once... We should use named variables if without it the body of the function becomes unmaintainable. But parse_dd() is so small that it's not affected. And it frees a CPU register. Bruno |