Re: [Check-devel] Minor Check code changes

[Michael P. <mpi...@dd...>]

The only alternative I can find on Windows is g_mkstemp()
https://developer.gnome.org/glib/2.37/glib-File-Utilities.html#g-mkstemp

However the patch is turning out to be more complicated than I thought.  It  might be better to leave it alone if no one is having problems.

Thanks
Mike P


From: Branden Archer [mailto:b.m...@gm...]
Sent: Wednesday, June 25, 2014 9:22 AM
To: Michael Piszczek
Cc: Che...@li...
Subject: Re: [Check-devel] Minor Check code changes

It turns out that both MinGW and MSVC do not have mkstemp(). Maybe that is not so surprising, as mkstemp() is a POSIX extension, whereas tempnam() is ISO C90.

I cannot find an obvious alternative for mkstemp() that would be a better replacement for tempnam() on Windows. Anything come to mind?

On Tue, Jun 24, 2014 at 10:44 PM, Branden Archer <b.m...@gm...<mailto:b.m...@gm...>> wrote:
Thanks for the patch!

The only change which will be made is to remove the pid stuff; it is not needed anymore as mkstemp will guarantee the file is unique.

-        uniq_tmp_file = ck_strdup_printf("%s/check_%d_XXXXXX", tmp, getpid());
+        uniq_tmp_file = ck_strdup_printf("%s/check_XXXXXX", tmp);

I will give this a try on MinGW and MSVC to make sure that they both have mkstemp() available. If so, I will push the change and let you know.