Re: [Celestia-developers] Keep getting memory leak reports in modelfile.cpp

[Da W. J. <dir...@gm...>]

I found several other memory leaks. To keep track of them, I filed bug
#1842551 on the sf.net tracker
(http://sourceforge.net/tracker/index.php?func=detail&aid=1842551&group_id=21302&atid=121302)

In short: there are leaks confirmed in scriptmenu.cpp, virtualtex.cpp,
and modelfile.cpp. (I'll attach a patch soon)
There are also other suspected leaks in: shadermanager.cpp,
galaxy.cpp, octree.h, model.cpp. (I'd like a second opinion on these
"suspected" leaks)

FWIW, there were also some leaks detected in the Mac gui, but I've
managed to fix all of these (will be in CVS soon).

Cheers,
DW


On Nov 30, 2007 1:27 PM, Toti wrote:
> On Wednesday 28 November 2007 13:16:17 Da Woon Jung wrote:
> > I keep getting claims from a memory leak checker that the following is
> > a leak in modelfile.cpp:
> >
> > Isn't this a genuine leak?
> It is. The VertexDescriptor attribute in Mesh is assigned from vertexDesc in
> setVertexDescriptor(), causing a deep copy of its internal data. The
> vertexDesc pointer should be freed after that call.
>