From: Pedro A. <pe...@co...> - 2010-01-31 16:39:35
|
On Sunday 31 January 2010 16:26:38, Dave Korn wrote: > -#if defined(UNDER_CE) && defined(__arm__) > +#if defined(__UNDER_CE__) && defined(__arm__) > -#ifdef UNICODE > +#ifdef __UNICODE__ > Do those look sensible to you? There could conceivably be some knock-on > effect of having all the fixed headers for the first time. Indeed. Those look harmless, and could potentially be TRT when building with strict standards. Both UNDER_CE and UNICODE are builtin defines: >arm-mingw32ce-gcc -dM -E - < /dev/null | grep UNICODE #define UNICODE 1 #define _UNICODE 1 #define __UNICODE__ 1 #define __UNICODE 1 >arm-mingw32ce-gcc -ansi -dM -E - < /dev/null | grep UNICODE #define _UNICODE 1 #define __UNICODE__ 1 #define __UNICODE 1 Or, maybe we should force the non-underscored versions to be always present, given that these are "standard" Windows defines. These look pretty busted though: --- /opt/mingw32ce-0.59/arm-mingw32ce/include/windef.h 2010-01-31 15:10:18.000000000 +0000 +++ /opt/mingw32ce-0.59/lib/gcc/arm-mingw32ce/4.4.0/include-fixed/windef.h 2010-01-31 15:21:19.000000000 +0000 : : -#ifndef WIN32 +#ifndef __WIN32__ #define WIN32 #endif : -#ifndef _fastcall +#ifndef __fastcall__ #define _fastcall __attribute__((fastcall)) #endif I couldn't find yet where are the fixinclude rules that cause all these changes. (looking at these rules for the first time). -- Pedro Alves |