Re[1]: [CEDET-devel] Improvement of senator search filtering

[Eric M. L. <er...@si...>]

Hi David,

  This sounds like a good idea.  If the values of the hook you are
thinking of are mode-specific, perhaps an override method would be
better.  If it is user centric, then a hook is better.  If both,
perhaps both?

  It may be that some of these concepts could be moved down into core
libraries.  For example, would this filter be related to speedbar,
ECB, or imenu in terms of tag listings?

  For now though, senator is a find place for it until the other
aspects are more clear.

Thanks!
Eric

>>> David PONCE <dav...@wa...> seems to think that:
>Hi Eric,
>
>Following my previous patch to senator.el to improve the robustness of
>`senator-search-tag-name', here is another change to use a hook instead
>of a simple variable to filter searched tags.
>
>The advantage of using a hook is that it allows to have both buffer
>local and global filters active at the same time in that order. I
>provided a default global filter to ignore code and block
>tags. Default ignored tag classes are customizable. The
>`senator-search-set-tag-class-filter' command uses the new hook to add
>a buffer local filter.
>
>WDYT? If you agree with that change I can commit it.
>
>Thanks.
>David
>
>2005-05-18  David Ponce  <da...@dp...>
>
>	* cedet/semantic/senator.el
>
>	(senator-search-ignore-tag-classes)
>	(senator--search-filter): New variables.
>	(senator-search-default-tag-filter): New function.
>	(senator-search-tag-filter): Remove.
>	(senator-search-tag-filter-functions): New hook.
>	(senator-search): Use it.
>	(senator-search-set-tag-class-filter): Likewise. Doc fix.
>	
  [ ... ]

-- 
          Eric Ludlam:                 za...@gn..., er...@si...
   Home: http://www.ludlam.net            Siege: www.siege-engine.com
Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org