Re[1]: [CEDET-devel] [eieio] :before and :after methods not called

[Eric M. L. <er...@si...>]

>>> drkm <dar...@ya...> seems to think that:
>drkm <dar...@ya...> writes:
>
>> "Eric M. Ludlam" <er...@si...> writes:
>
>>>   I checked in changes to eieio to do this mechanism for method calls.
>>> I submitted a new test file for methodinvocation tests.
>
>>   Good news.
>
>  I just take a look at this new file.  In the second test, you
>include (F :PRIMARY B-base2) in the result, if I understand.  IMHO, it
>must not be there.

I restored the original behavior here.

  [ ... ]
>  BTW, in the first test, I think it's better to not define
>(F :PRIMARY AAA).  So the result will have to be:
>
>    (F :BEFORE AAA)
>    (F :BEFORE AA)
>    (F :BEFORE A)
>    (F :PRIMARY AA)
>    (F :AFTER A)
>    (F :AFTER AA)
>    (F :AFTER AAA)

I changed the test to this.

>  I guess starting at different "levels" could be better for testing.
>Maybe introduce a "hole" in the :BEFORE and :AFTER lists could be of
>some benefit, too.  Like something like that:
>
>    (F :BEFORE AAA)
>    (F :BEFORE A)
>    (F :PRIMARY AA)
>    (F :AFTER A)
>    (F :AFTER AAA)
>
>  To be sure the implementation don't just walk in the class
>inheritence graph until some nil is encountered (or something like
>that).
  [ ... ]

This was a good suggestion as it revealed a bug.  I have a method
optimizer which conflicts with the new method-list generator, so I
ended up with 2 calls to the A implementation of F :BEFORE.  I checked
in a fix for this also.

Now perhaps I can get to some of your other messages. ;)

Eric

-- 
          Eric Ludlam:                 za...@gn..., er...@si...
   Home: http://www.ludlam.net            Siege: www.siege-engine.com
Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org