[CEDET-devel] Re: Tags for anonymous java classes

[Eric M. L. <er...@si...>]

Hi,

  Your imenu change makes good sense.  I can certainly imagine
languages that would have more than one style of expandable tag for
non-programming languages.

  Anonymous classes also sounds like a grand idea as I know there have
been some requests for them.

  I do wonder about using :members for a variable.  I don't know the
java construct here, but in C you can write this:

struct {
   int a;
   char b;
} variablename;

and in this case the datatype of `variablename' is itself a TYPE-TAG
declaration.  Does that make any sense in the java context?

I seem to remember having this conversation before but cannot recall
the outcome.

If possible, it would be nice to make them both the same so that the
analyzer knows what to do.

Eric


>>> dav...@wa... seems to think that:
>Hi Eric,
>
>Following users' requests to have semantic generate tags for anonymous
>classes, you will find an implementation in the following patch.
>
>As anonymous classes are part of variable initializers expression, I
>considered them as member components of field declarations.
>
>Also to have anonymous classes appear in imenu, I improved
>semantic-imenu, and replaced `semantic-imenu-expandable-tag-class' by
>an equivalent `semantic-imenu-expandable-tag-classes' that receives a
>list of tag classes to expand instead of a single class.
>
>wisent-java uses that to build sub menus for anonymous classes found
>in variable definitions.
>
>I did some quick tests and all seemed to work as expected :-)
>
>However, I would like to have your feedback before to commit these
>changes.
  [ ... ]

-- 
          Eric Ludlam:                 za...@gn..., er...@si...
   Home: http://www.ludlam.net            Siege: www.siege-engine.com
Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org