Re: [CEDET-devel] Problem in semantic-change-function

[<er...@si...>]

Looks good to me.  Thanks

Eric

On Tue, 16 Sep 2003 20:25:29 +0200, David Ponce wrote:

> 
> > My computer is dead.  Would someone mind applying
this
> > patch for me?  (Unless, of course, you can think of
a
> > better way.) Thanks.
> 
> What a pity :-(
> 
> Do you agree with this version:
> 
> (defun semantic-changes-in-region (start end &optional
> buffer)
>    "Find change overlays which exist in whole or in
> part between START and END.
> Optional argument BUFFER is the buffer to search for
> changes in."
>    (save-excursion
>      (if buffer (set-buffer buffer))
>      (let ((ol (semantic-overlays-in (max start
> (point-min))
> 				    (min end (point-max))))
> 	  (ret nil))
>        (while ol
> 	(when (semantic-overlay-get (car ol)
'semantic-change)
> 	  (setq ret (cons (car ol) ret)))
> 	(setq ol (cdr ol)))
>        (sort ret #'(lambda (a b) (<
> (semantic-overlay-start a)
> 				   (semantic-overlay-start b)))))))
> 
> I used `min' and `max', replaced 0 by `point-min', and
> removed the unnecessary
> `let' inside the `while' loop ;-)
> 
> If no objection, I will check the fix.
> 
> David
> 
> 
> 
> 
>
-------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Cedet-devel mailing list
> Ced...@li...
>
https://lists.sourceforge.net/lists/listinfo/cedet-devel